New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render no image if media is present #2416

Merged

Rassl merged 1 commit into stakwork:master from MahtabBukhari:Render-no-image-if-media-is-present

Nov 8, 2024

Contributor

MahtabBukhari commented Oct 31, 2024 •

edited

Loading

Ticket №: #2415

closes #2415

Problem:

We should not render image_url if there is a media player present:

Evidence:

https://www.loom.com/share/f93215ef31fd48d49d64fe5e1414b135?sid=660a28ef-7585-439d-8692-44ba7fcc20d1


          fix(media-player): render no image if media is present

5f750e5

Contributor Author

MahtabBukhari commented Oct 31, 2024 •

edited

Loading

@tomsmith8 @Rassl Could you please review the PR?

Rassl approved these changes

View reviewed changes

Rassl merged commit 25893a3 into stakwork:master

17 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet